adding the ability to provide custom login token identity #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, the identity associated with the login token was the same as the identity associated with the one-time password.
for example, if the one-time-password was associated with an email address (e.g.
luigi@mansion), the identity that would be associated with their login token would also beluigi@mansion).sometimes, it might be useful to associate the login token with a different identity (for example, the id of the user that was created when when the OTP was used to confirm user's identity).
This change provides the ability to provide a function that would generate the identity for the login token. The function receives the One-Time-Passwords identity as its input parameter.